Skip to content

Improve and refactor API client drastically #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mike1858
Copy link
Member

@mike1858 mike1858 commented Aug 22, 2025

This PR improves the type safety of the frontend API client, reducing type errors across the frontend. It should also fix #29.

@mike1858
Copy link
Member Author

@bl-ue will you please review?

@bl-ue
Copy link
Member

bl-ue commented Aug 22, 2025

Linting errors.

> gemini-desktop@0.1.0 lint:ci /home/runner/work/gemini-desktop/gemini-desktop/frontend
> pnpm eslint src --max-warnings=0 && pnpm tsc --noEmit

Error: src/components/common/DirectorySelectionDialog.tsx(87,59): error TS2345: Argument of type 'string' is not assignable to parameter of type '{ path: string; }'.
Error: src/components/common/DirectorySelectionDialog.tsx(121,55): error TS2345: Argument of type 'string' is not assignable to parameter of type '{ path: string; }'.
Error: src/hooks/useFileSystemNavigation.ts(47,57): error TS2345: Argument of type 'string' is not assignable to parameter of type '{ path: string; }'.
Error: src/hooks/useFileSystemNavigation.ts(118,59): error TS2345: Argument of type 'string' is not assignable to parameter of type '{ path: string; }'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nothing shown in Web GUI
2 participants