finish reason mapping part 2 #1214
Conversation
|
Summary By MatterAI
🔄 What ChangedThis pull request, titled "finish reason mapping part 2", continues the effort to standardize 🔍 Impact of the ChangeThis change improves the interoperability and consistency of 📁 Total Files Changed
🧪 Test AddedN/A. No specific tests were mentioned or added in the provided patch. 🔒Security VulnerabilitiesNo security vulnerabilities were detected in the provided code patch. The changes primarily involve data transformation and type safety, without introducing new external inputs or insecure practices. MotivationThis change is part of an ongoing effort to standardize API responses across various LLM providers, specifically for Type of Change
How Has This Been Tested?
Screenshots (if applicable)N/A Checklist
Tanka Poem ♫
Sequence DiagramsequenceDiagram
participant Provider as LLM Provider (e.g., Anthropic)
participant TransformReason as transformFinishReason Utility
participant UnifiedResponse as Unified API Response
Provider->>Provider: Receive LLM Response
Provider->>Provider: Extract Provider-Specific Finish Reason (e.g., stop_reason, completionReason)
Provider->>TransformReason: Call transformFinishReason(providerReason, strictOpenAiCompliance)
TransformReason->>TransformReason: Map providerReason to FINISH_REASON enum
TransformReason-->>Provider: Return unified FINISH_REASON
Provider->>UnifiedResponse: Include unified FINISH_REASON in response
|
![matter-code-review[bot]](https://avatars.githubusercontent.com/in/474549?s=60&v=4){kind=small}
|
Important PR Review SkippedPR review skipped as per the configuration setting. Run a manually review by commenting /matter review 💡Tips to use Matter AICommand List
|
3 similar comments
|
Important PR Review SkippedPR review skipped as per the configuration setting. Run a manually review by commenting /matter review 💡Tips to use Matter AICommand List
|
|
Important PR Review SkippedPR review skipped as per the configuration setting. Run a manually review by commenting /matter review 💡Tips to use Matter AICommand List
|
|
Important PR Review SkippedPR review skipped as per the configuration setting. Run a manually review by commenting /matter review 💡Tips to use Matter AICommand List
|
narengogi
changed the title
|
Important PR Review SkippedPR review skipped as per the configuration setting. Run a manually review by commenting /matter review 💡Tips to use Matter AICommand List
|
|
Important PR Review SkippedPR review skipped as per the configuration setting. Run a manually review by commenting /matter review 💡Tips to use Matter AICommand List
|
|
@narengogi Can you please resolve conflicts? |
narengogi
force-pushed
the
chore/finish-reason-mapping-part-2
branch
from
75d024a to
3bcb84f
Compare
|
Important PR Review SkippedPR review skipped as per the configuration setting. Run a manually review by commenting /matter review 💡Tips to use Matter AICommand List
|
stop reason for google bedrock titan finish reason fix fix finish reason for deepseek fix finish reason for mistral fix finish reason for together ai changes from self review fix finish reason for anthropic completions
narengogi
force-pushed
the
chore/finish-reason-mapping-part-2
branch
from
3bcb84f to
56b62e1
Compare
|
Important PR Review SkippedPR review skipped as per the configuration setting. Run a manually review by commenting /matter review 💡Tips to use Matter AICommand List
|
|
Important PR Review SkippedPR review skipped as per the configuration setting. Run a manually review by commenting /matter review 💡Tips to use Matter AICommand List
|
Status of finish reason mapping by provider (only mentioning providers which are not openai compliant)