Skip to content

feat: NEX 4.x.x compatibility #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 16, 2025
Merged

feat: NEX 4.x.x compatibility #56

merged 10 commits into from
Aug 16, 2025

Conversation

TraceEntertains
Copy link
Member

@TraceEntertains TraceEntertains commented Jul 9, 2025

Resolves #XXX

Changes:

Fix TicketGranting, UpdateNotificationData methods for NEX 4.x.x, Fix NotificationData structure for NEX 4.x.x.
fix some attribute 1 errors in FindMatchmakeSessionBySearchCriteria (yes this last one isn't NEX 4 but it is a very useful fix) Removed from this pull request, will create new one later

@DaniElectra DaniElectra self-requested a review July 9, 2025 19:10
@jonbarrow
Copy link
Member

I'll give this a proper review in a bit, but in the future can you please make smaller, more focused, commits that each change specific things, rather than single commits that touch many areas, when possible? Same thing with the PRs themselves, the NEX 4 changes should be in a separate PR from the general matchmaking changes so that we are trying to review multiple "types" of changes all at once

Since there's only a single commit right now I THINK this can still be fixed without much issue, by reverting the changes, making new commits, and force-pushing back? I'll CC @DaniElectra for thoughts on that. If not it's not a huge deal, just something for the future then

@TraceEntertains
Copy link
Member Author

TraceEntertains commented Jul 10, 2025

Removed the attribute 1 fix from this, sorry about not splitting the notification stuff and ticketgranting stuff into separate commits, I kinda forgot and don't think it warrants a second force push 😭

Copy link
Member

@DaniElectra DaniElectra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important note that the database update is a breaking change. It won't affect current databases (since games we currently support only use uint32 values), but we should consider doing something about it

@TraceEntertains
Copy link
Member Author

Important note that the database update is a breaking change. It won't affect current databases (since games we currently support only use uint32 values), but we should consider doing something about it

I have literally no ideas for how to avoid breaking databases so I am open to ideas :P

Copy link
Member

@jonbarrow jonbarrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, thank you! Just a couple minor things outside of what @DaniElectra brought u[

@DaniElectra
Copy link
Member

I have literally no ideas for how to avoid breaking databases so I am open to ideas :P

I don't think there's a way to avoid breaking changes, so we will just have to migrate all existing ones

@DaniElectra
Copy link
Member

Similarly to Login, the RequestTicket error log needs to be updated the same way 😅

Once that gets updated the PR should be finally done

@DaniElectra DaniElectra merged commit 991adb0 into main Aug 16, 2025
2 checks passed
@TraceEntertains TraceEntertains deleted the feat/nex-4.x.x-fixes branch August 16, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants