-
Notifications
You must be signed in to change notification settings - Fork 61
Add Adsorbml recipe for MLPs #2732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zulissimeta
wants to merge
22
commits into
Quantum-Accelerators:main
Choose a base branch
from
zulissimeta:adsorbml_recipe
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add Adsorbml recipe for MLPs #2732
zulissimeta
wants to merge
22
commits into
Quantum-Accelerators:main
from
zulissimeta:adsorbml_recipe
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR adds an AdsorbML-type recipe to predict adsorption energies using a MLP.
Given a slab:
Also, a second flow to
The total energy MLPs in the current tests are trained on PBE data, so the adsorption energies should also be PBE-level predictions (i.e. not great for small molecule adsorption energies). Using a MLP trained on RPBE data should generate results much closer to experimental adsorption energies. This is tested for OCP referenced adsorption energy predictions.
The full AdsorbML pipeline (consistent with the paper above) would be:
Example to calculate CO binding energies on all low Miller-index facets for Cu with ML-only relaxations
Example to also do OC20-compatible DFT single-point validations and an RPBE-compatible bulk relaxation
Failing tests can be addressed with
Requirements
main
).Note: If you are an external contributor, you will see a comment from @buildbot-princeton. This is solely for the maintainers.