Skip to content

feat: forward transmission response spectrum #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jul 18, 2025

Conversation

jelsvanarragon
Copy link
Contributor

Checklist

Thank you for contributing to HarmonicSteadyState.jl! Please make sure you have finished the following tasks before finishing the PR.

  • Appropriate tests were added and tested locally by running: make test.
  • Any code changes should be julia formatted by running: make format.
  • All documents (in docs/ folder) related to code changes were updated and able to build locally by running: make docs.

Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.

Description

Describe the proposed change here.

Related issues or PRs

Please mention the related issues or PRs here. If the PR fixes an issue, use the keyword close/closes/closed/fix/fixes/fixed/resolve/resolves/resolved followed by the issue id, e.g. fix #[id]

Additional context

Copy link

codecov bot commented Jun 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.81%. Comparing base (1442ef8) to head (3f824e2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
+ Coverage   82.36%   82.81%   +0.44%     
==========================================
  Files          32       33       +1     
  Lines        1378     1414      +36     
==========================================
+ Hits         1135     1171      +36     
  Misses        243      243              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@oameye oameye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution!!! I have added some comments to the implementation. I also translated you notebook as an example of the docs. This you can find under examples.

@oameye
Copy link
Member

oameye commented Jun 27, 2025

What would be required to plot S11?

@oameye oameye linked an issue Jun 27, 2025 that may be closed by this pull request
@oameye oameye changed the title Added S21 calculation code feat: forward transmission response spectrum Jun 27, 2025
@oameye oameye merged commit 75ee854 into QuantumEngineeredSystems:main Jul 18, 2025
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S_11 and S_22 throught dynamical matric
2 participants