-
Notifications
You must be signed in to change notification settings - Fork 2
feat: forward transmission response spectrum #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: forward transmission response spectrum #50
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
==========================================
+ Coverage 82.36% 82.81% +0.44%
==========================================
Files 32 33 +1
Lines 1378 1414 +36
==========================================
+ Hits 1135 1171 +36
Misses 243 243 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the contribution!!! I have added some comments to the implementation. I also translated you notebook as an example of the docs. This you can find under examples.
What would be required to plot S11? |
Checklist
Thank you for contributing to
HarmonicSteadyState.jl
! Please make sure you have finished the following tasks before finishing the PR.make test
.julia
formatted by running:make format
.docs/
folder) related to code changes were updated and able to build locally by running:make docs
.Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.
Description
Describe the proposed change here.
Related issues or PRs
Please mention the related issues or PRs here. If the PR fixes an issue, use the keyword close/closes/closed/fix/fixes/fixed/resolve/resolves/resolved followed by the issue id, e.g. fix #[id]
Additional context