Skip to content

[radar-output] Fix path format config #4806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

mpgxvii
Copy link
Member

@mpgxvii mpgxvii commented Jul 28, 2025

Description of the change

    # Path settings
    paths:
      # Additional properties
      properties:
        format: "${projectId}/${userId}/${topic}/${time:yyyyMMdd}${attempt}${extension}"

It should be:

    # Path settings
    paths:
      # Additional properties
      path:
        format: "${projectId}/${userId}/${topic}/${time:yyyyMMdd}${attempt}${extension}"

Benefits

Possible drawbacks

Applicable issues

  • fixes #

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [<name_of_the_chart>])

@mpgxvii mpgxvii requested a review from yatharthranjan July 28, 2025 10:26
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching charts/*/values.yaml:

  • Is the PR adding a new container? Please reviewer, add it to the models (internal process)
  • Is the PR adding a new parameter? Please, ensure it’s documented in the README.md

This is an automatically generated QA checklist based on modified files.

@yatharthranjan
Copy link
Member

how was this working in previous deployments, was there a change that broke it?

@yatharthranjan
Copy link
Member

@mpgxvii
Copy link
Member Author

mpgxvii commented Jul 28, 2025

According to code here - https://github.com/RADAR-base/radar-output-restructure/blob/4a7a3c79ea3797fdacd8cdabe6426e759e7bd1fe/src/main/java/org/radarbase/output/config/PathConfig.kt#L49

It should pass the properties to pathformatter too.

Ah yes but it seems to be only overriding the properties object rather than the format and plugin values?

@yatharthranjan
Copy link
Member

ah i see, good point. I was just wondering how was it working previously if there were no changes to the code?

Given that old deployments also have this configured, should we keep the property names same in the helm chart?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants