removed deprecated typing #395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RagnarGrootKoerkamp
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Looks like collections.abc was added in 3.3 so this should be fine :)
https://docs.python.org/3/library/collections.abc.html#module-collections.abc
edit: ah wait; the new [] annotations on it are only 3.9 I think? Ah well should still be fine.
|
We say that we require 3.10 anyway? |
mpsijm
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like python 3.9 deprecated some of those typing stuff https://docs.python.org/3/library/typing.html