Py39/cantera26 arm #2765
Merged
Py39/cantera26 arm #2765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is handled in the env file
|
@jonwzheng looks like this is working - if this passes all CI can you please review and merge if all looks good? |
jonwzheng
previously approved these changes
Feb 25, 2025
jonwzheng
reviewed
Feb 25, 2025
jonwzheng
dismissed
their stale review
premature approval (tests had not finished running)
I think it is just because the ARM macs have slightly different floating point rounding errors than the intel macs. Loosened the test requirement in a101ec4 |
|
@jonwzheng the reg test is failing because of upstream thing (I think we need to rebase the branch of RMS we are using) so I am going to go ahead and merge all the PRs and then try to fix it in the base one |
|
okay! sounds good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.9 upgrade doesn't work with ARM Mac + RMS.
This is because we currently run ARM macs in x86 emulation mode (since
canteradoesn't have ARM Mac binaries) which (for some reason) breaks RMS compatibility.Instead of upgrading cantera version (#2751) to resolve this, we will just change the channel from which we install
canterato one which has binaries we need.