-
Notifications
You must be signed in to change notification settings - Fork 244
Add yaml input file support #2844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add yaml input file support #2844
Conversation
- Add YAMLInputReader class to parse YAML input files - Add auto-detection of input file format based on extension - Support all existing RMG features in YAML format - Add example YAML input files This allows users to write RMG input files in YAML format as an alternative to Python files, providing better structure and validation.
…to process solvents n stuff but ill do that soon
Regression Testing Results
Detailed regression test results.Regression test aromatics:Reference: Execution time (DD:HH:MM:SS): 00:00:00:50 aromatics Failed Core Comparison ❌Original model has 15 species. aromatics Failed Edge Comparison ❌Original model has 106 species. Non-identical thermo! ❌
Identical thermo comments:
Observables Test Case: Aromatics Comparison
✅ All Observables varied by less than 0.500 on average between old model and new model in all conditions! aromatics Passed Observable Testing ✅Regression test liquid_oxidation:Reference: Execution time (DD:HH:MM:SS): 00:00:02:01 liquid_oxidation Failed Core Comparison ❌Original model has 37 species. liquid_oxidation Failed Edge Comparison ❌Original model has 214 species. Non-identical kinetics! ❌
kinetics:
Observables Test Case: liquid_oxidation Comparison
✅ All Observables varied by less than 0.100 on average between old model and new model in all conditions! liquid_oxidation Passed Observable Testing ✅Regression test nitrogen:Reference: Execution time (DD:HH:MM:SS): 00:00:01:02 nitrogen Passed Core Comparison ✅Original model has 41 species. nitrogen Passed Edge Comparison ✅Original model has 133 species.
Observables Test Case: NC Comparison
✅ All Observables varied by less than 0.200 on average between old model and new model in all conditions! nitrogen Passed Observable Testing ✅Regression test oxidation:Reference: Execution time (DD:HH:MM:SS): 00:00:01:51 oxidation Failed Core Comparison ❌Original model has 59 species. oxidation Failed Edge Comparison ❌Original model has 230 species.
Observables Test Case: Oxidation Comparison
The following observables did not match: ❌ Observable species [OH] varied by more than 0.500 on average between old model OH(5) and new model OH(5) in condition 1.
oxidation Failed Observable Testing ❌Errors occurred during observable testing
WARNING:root:Initial mole fractions do not sum to one; normalizing.
|
Motivation or Problem
Description of Changes
YAMLInputReader
class inyaml_input_reader.py
input.py
to support both formatsTesting
Reviewer Tips