Fix Money gem Vulnerability issue #1101
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emorgan67
force-pushed
the
money-gem-patch
branch
2 times, most recently
from
dc793b3 to
1cabc66
Compare
emorgan67
force-pushed
the
money-gem-patch
branch
from
1cabc66 to
2d0b054
Compare
tagliala
reviewed
May 31, 2024
| elsif format == :yaml | ||
| warn '[WARNING] Using :yaml format when importing rates is potentially unsafe and ' \ | ||
| 'might lead to remote code execution via Marshal.load deserializer. Consider using ' \ | ||
| 'safe alternatives such as :json and :ruby.' |
There was a problem hiding this comment.
Hi, I guess that :ruby is not safe either, so this should advise to use json only (same for line 267)
|
Isn’t this an issue only in Ruby versions before 3.1 where loading YAML used an unsafe load? Since we don't support versions before 3.1 and Psych's new YAML loading does not load any unauthorized types, I think this is no longer an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.