update README with customising currency symbol example #1102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tagliala
reviewed
May 31, 2024
|
Hi @tagliala |
|
Hi @ptadros , sorry but I'm not a maintainer. I did a review because I was submitting a PR myself and I was interested in a "shortcut" to customize currency symbol |
sunny
reviewed
Jun 26, 2025
| @@ -455,6 +455,12 @@ m = Money.from_cents('123', :gbp) # => #<Money fractional:123 currency:GBP> | |||
| m.format(symbol: m.currency.to_s + ' ') # => "GBP 1.23" | |||
| ``` | |||
|
|
|||
| If you would like to customise currency symbols (e.g to avoid ambiguous between currencies), you can set custom symbol for specific currency as following | |||
There was a problem hiding this comment.
Minor English fixes and shortening suggestion:
Suggested change
| If you would like to customise currency symbols (e.g to avoid ambiguous between currencies), you can set custom symbol for specific currency as following | |
| If you would like to customize currency symbols to avoid ambiguity between currencies, you can: |
| If you would like to customise currency symbols (e.g to avoid ambiguous between currencies), you can set custom symbol for specific currency as following | ||
|
|
||
| ```ruby | ||
| Money::Currency.table[:hkd][:symbol] = 'HK$' |
There was a problem hiding this comment.
We can remove the indentation here.
Suggested change
| Money::Currency.table[:hkd][:symbol] = 'HK$' | |
| Money::Currency.table[:hkd][:symbol] = 'HK$' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Sometimes, there are currencies which have multiple symbols (e.g Hong Kong Dollar can be represented with
$orHK$. When an application supports multiple currencies, this produces ambiguous interpretation which currency is displayed (.e.g USD or HKD). This PR adds an example to the README how to do it (e.g can be placed in the gem initialiser in rails app).Changes
Tests