feat: 🎸 [HCPSDKFIORIUIKIT-2680] Migrate What's New component #1206
Conversation
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| /// producing an optional view that is visible only when the condition | ||
| /// evaluates to `true`. | ||
| public static func buildIf(_ content: (some View)?) -> some WhatsNewPageList { | ||
| SingleWhatsNewPage(view: content == nil ? AnyView(EmptyView()) : AnyView(content!)) |
There was a problem hiding this comment.
Force Unwrapping Violation: Force unwrapping should be avoided. (force_unwrapping)
| WhatsNewPagePair(first: c0, remainder: WhatsNewPagePair(first: c1, remainder: WhatsNewPagePair(first: c2, remainder: WhatsNewPagePair(first: c3, remainder: WhatsNewPagePair(first: c4, remainder: WhatsNewPagePair(first: c5, remainder: WhatsNewPagePair(first: c6, remainder: WhatsNewPagePair(first: c7, remainder: SingleWhatsNewPage(view: c8))))))))) | ||
| } | ||
|
|
||
| public static func buildBlock(_ c0: some View, _ c1: some View, _ c2: some View, _ c3: some View, _ c4: some View, _ c5: some View, _ c6: some View, _ c7: some View, _ c8: some View, _ c9: some View) -> some WhatsNewPageList { |
There was a problem hiding this comment.
Function Parameter Count Violation: Function should have 5 parameters or less: it currently has 10 (function_parameter_count)
Missing Docs Violation: public declarations should be documented. (missing_docs)
| WhatsNewPagePair(first: c0, remainder: WhatsNewPagePair(first: c1, remainder: WhatsNewPagePair(first: c2, remainder: WhatsNewPagePair(first: c3, remainder: WhatsNewPagePair(first: c4, remainder: WhatsNewPagePair(first: c5, remainder: WhatsNewPagePair(first: c6, remainder: SingleWhatsNewPage(view: c7)))))))) | ||
| } | ||
|
|
||
| public static func buildBlock(_ c0: some View, _ c1: some View, _ c2: some View, _ c3: some View, _ c4: some View, _ c5: some View, _ c6: some View, _ c7: some View, _ c8: some View) -> some WhatsNewPageList { |
There was a problem hiding this comment.
Function Parameter Count Violation: Function should have 5 parameters or less: it currently has 9 (function_parameter_count)
Missing Docs Violation: public declarations should be documented. (missing_docs)
| WhatsNewPagePair(first: c0, remainder: WhatsNewPagePair(first: c1, remainder: WhatsNewPagePair(first: c2, remainder: WhatsNewPagePair(first: c3, remainder: WhatsNewPagePair(first: c4, remainder: WhatsNewPagePair(first: c5, remainder: SingleWhatsNewPage(view: c6))))))) | ||
| } | ||
|
|
||
| public static func buildBlock(_ c0: some View, _ c1: some View, _ c2: some View, _ c3: some View, _ c4: some View, _ c5: some View, _ c6: some View, _ c7: some View) -> some WhatsNewPageList { |
There was a problem hiding this comment.
Function Parameter Count Violation: Function should have 5 parameters or less: it currently has 8 (function_parameter_count)
Missing Docs Violation: public declarations should be documented. (missing_docs)
| WhatsNewPagePair(first: c0, remainder: WhatsNewPagePair(first: c1, remainder: WhatsNewPagePair(first: c2, remainder: WhatsNewPagePair(first: c3, remainder: WhatsNewPagePair(first: c4, remainder: SingleWhatsNewPage(view: c5)))))) | ||
| } | ||
|
|
||
| public static func buildBlock(_ c0: some View, _ c1: some View, _ c2: some View, _ c3: some View, _ c4: some View, _ c5: some View, _ c6: some View) -> some WhatsNewPageList { |
There was a problem hiding this comment.
Function Parameter Count Violation: Function should have 5 parameters or less: it currently has 7 (function_parameter_count)
Missing Docs Violation: public declarations should be documented. (missing_docs)
| WhatsNewPagePair(first: c0, remainder: WhatsNewPagePair(first: c1, remainder: WhatsNewPagePair(first: c2, remainder: WhatsNewPagePair(first: c3, remainder: SingleWhatsNewPage(view: c4))))) | ||
| } | ||
|
|
||
| public static func buildBlock(_ c0: some View, _ c1: some View, _ c2: some View, _ c3: some View, _ c4: some View, _ c5: some View) -> some WhatsNewPageList { |
There was a problem hiding this comment.
Function Parameter Count Violation: Function should have 5 parameters or less: it currently has 6 (function_parameter_count)
Missing Docs Violation: public declarations should be documented. (missing_docs)
|
|
||
| public extension WhatsNewPageList { | ||
| var isEmpty: Bool { | ||
| count == 0 |
There was a problem hiding this comment.
Empty Count Violation: Prefer checking isEmpty over comparing count to zero. (empty_count)
No description provided.