feat: 🎸 [HCPSDKFIORIUIKIT-2999] tool bar buttons update #1229
Conversation
Update to fixed size for buttons in navigation bar.
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| let config = FioriButtonConfiguration(foregroundColor: foregroundColor, | ||
| backgroundColor: Color.clear, | ||
| font: .fiori(forTextStyle: .body, weight: .semibold), | ||
| padding: EdgeInsets(top: 0, leading: 0, bottom: 0, trailing: 0),) |
There was a problem hiding this comment.
Comma Spacing Violation: There should be no space before and one after any comma. (comma)
| let config = FioriButtonConfiguration(foregroundColor: foregroundColor, | ||
| backgroundColor: Color.clear, | ||
| font: .fiori(forTextStyle: .body, weight: .semibold), | ||
| padding: EdgeInsets(top: 0, leading: 0, bottom: 0, trailing: 0),) |
There was a problem hiding this comment.
Comma Spacing Violation: There should be no space before and one after any comma. (comma)
| let config = FioriButtonConfiguration(foregroundColor: foregroundColor, | ||
| backgroundColor: Color.clear, | ||
| font: .fiori(forTextStyle: .body, weight: .semibold), | ||
| padding: EdgeInsets(top: 0, leading: 0, bottom: 0, trailing: 0),) |
There was a problem hiding this comment.
Comma Spacing Violation: There should be no space before and one after any comma. (comma)
| let config = FioriButtonConfiguration(foregroundColor: foregroundColor, | ||
| backgroundColor: Color.clear, | ||
| font: .fiori(forTextStyle: .body, weight: .semibold), | ||
| padding: EdgeInsets(top: 0, leading: 0, bottom: 0, trailing: 0),) |
There was a problem hiding this comment.
| padding: EdgeInsets(top: 0, leading: 0, bottom: 0, trailing: 0),) | |
| padding: EdgeInsets(top: 0, leading: 0, bottom: 0, trailing: 0)) |
There was a problem hiding this comment.
The build failed with error msg:
❌ /Users/runner/work/cloud-sdk-ios-fiori/cloud-sdk-ios-fiori/Sources/FioriSwiftUICore/FioriButton/FioriButtonStyle.swift:262:111: unexpected ',' separator
padding: EdgeInsets(top: 0, leading: 0, bottom: 0, trailing: 0),)
^
Testing failed:
Unexpected ',' separator
Command SwiftCompile failed with a nonzero exit code
Testing cancelled because the build failed.
** TEST FAILED **
Update to fixed size for buttons in navigation bar.