Skip to content

chore: Skip as keyword and aliases in barrel files when checking public APIs #5945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ZhongpinWang
Copy link
Contributor

Having aliases defined by as keyword in barrel files was causing issue (found in SAP/ai-sdk-js/pull/880).

So previously, export { foo as bar } from './somefile.js'; causes issue fooasbar is exported but marked as internal.

Now we use regex to match and replace as keyword and aliases. These should not be checked.

@ZhongpinWang ZhongpinWang requested a review from deekshas8 July 24, 2025 11:35
@deekshas8 deekshas8 enabled auto-merge (squash) July 30, 2025 08:26
@deekshas8 deekshas8 merged commit f602bce into main Jul 30, 2025
16 checks passed
@deekshas8 deekshas8 deleted the chore-skip-aliases-in-barrel-files-for-public-api-check branch July 30, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants