Skip to content

chore: Remove @definitelytyped/dtslint dep #5950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 30, 2025
Merged

Conversation

deekshas8
Copy link
Contributor

@deekshas8 deekshas8 commented Jul 29, 2025

There is SCV for this dependency. Though axios uses the latest one, I am not sure why that is the culprit according to https://github.com/SAP/cloud-sdk-js/security/dependabot/108.

definitelyTyped/utils -> @qiwi/npm-registry-client -> request (deprecated) -> form-data (2.3.2) is what I could find.
Anyway the resolution should fix the dependency to the older version.

UPDATE: The @definitelyTyped/utils is not needed and has been removed. This also removes the transitive dependency to the vulnerable form-data. Therefore no need for resolution

@deekshas8 deekshas8 requested a review from ZhongpinWang July 29, 2025 15:59
@deekshas8 deekshas8 changed the title fix: Add resolution for form-data dep chore: Add resolution for form-data dep Jul 29, 2025
@ZhongpinWang ZhongpinWang changed the title chore: Add resolution for form-data dep chore: Remove @definitelytyped/dtslint dep Jul 30, 2025
Copy link
Contributor

@ZhongpinWang ZhongpinWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will remove @definitelytyped/dtslint instead as it is not used anywhere.

LGTM, thanks for taking care.

@deekshas8 deekshas8 enabled auto-merge (squash) July 30, 2025 08:23
@deekshas8 deekshas8 merged commit fc32e4b into main Jul 30, 2025
19 checks passed
@deekshas8 deekshas8 deleted the form-data-resolution branch July 30, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants