-
Notifications
You must be signed in to change notification settings - Fork 38
Fix clutter 2108 #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
achilesfontanamota
wants to merge
542
commits into
SIMULATOR-WG:development
Choose a base branch
from
Radio-Spectrum:fix_clutter_2108
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix clutter 2108 #125
achilesfontanamota
wants to merge
542
commits into
SIMULATOR-WG:development
from
Radio-Spectrum:fix_clutter_2108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implementation of NGSO Orbit model * Creation of the MSS-D2D system within SHARC * Creation of satellite folder with usefull satellite system modules * WIP: Creation of the mss_d2d_to_imt campaign
…T station simulations
…um/SHARC into feat_mss_d2d_to_imt
Co-authored-by: Artur P. P. <89547366+artistrea@users.noreply.github.com>
Co-authored-by: Artur P. P. <89547366+artistrea@users.noreply.github.com>
single space station or single earth station categories.
Co-authored-by: Artur P. P. <89547366+artistrea@users.noreply.github.com>
Co-authored-by: Artur P. P. <89547366+artistrea@users.noreply.github.com>
Co-authored-by: Artur P. P. <89547366+artistrea@users.noreply.github.com>
Implementation of MSS-D2D
…paign Update/mss d2d to imt campaign
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have updated section 3.3 of the 2108. To do that, I have created the variable "mean_clutter_height" to "param_p619". This is a new variable used in the new version of 2108. Moreover, I also added the variable "below_rooftop", which represents the percentage of stations where clutter is applied.
For P.452, I have added the possibility of adding clutter to one-side or both sides, by adding the variable "clutter_type" to param_p452.
Finally, I have fixed the z component of the single_space station in "station_factory", since we do not use height anymore:
space_station.z = space_station.height