Fix typos and add exceptions to .typos.toml #1310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrects spelling errors throughout the codebase: - casues → causes - vertexes → vertices (multiple instances) - Hass → Haas (author name) - lenth → length - ine → one - elminated → eliminated - teh → the - Lke → Like - sumary → summary (variable names) - additonal → additional Adds exceptions for legitimate scientific terms: - Pase (phosphatase enzyme suffix) - Ba (part of BaF3 cell line name) Fixes failing typos CI check. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
ChrisRackauckas
commented
Aug 2, 2025
ChrisRackauckas
commented
Aug 2, 2025
| @@ -232,7 +232,7 @@ let | |||
| J.nzval[3:3:(end - 4)] .= p[3] | |||
|
|
|||
| # Non-spatial | |||
| for i in 1:1:Int64(lenth(u) / 2 - 1) | |||
| for i in 1:1:Int64(length(u) / 2 - 1) | |||
There was a problem hiding this comment.
Interesting this wasn't giving test failures before?
There was a problem hiding this comment.
Very weird. I guess this code was never getting call?
There was a problem hiding this comment.
Yeah, spatial_brusselator_jac_sparse doesn't seem to be used at all, only the dense Jacobian is used in the test script 😅
ChrisRackauckas
commented
Aug 2, 2025
test/spatial_modelling/lattice_reaction_systems_lattice_types.jl
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all spelling errors identified by the typos CI check and adds appropriate exceptions for legitimate scientific terms.
Changes Made
Spelling Corrections
casues→causes(in test comment)vertexes→vertices(multiple files, proper plural form)Hass→Haas(author name in bibliography)lenth→length(Julia function name)ine→one(comment text)elminated→eliminated(documentation)teh→the(documentation)Lke→Like(documentation)sumary→summary(variable names in documentation examples)additonal→additional(documentation)Exception Additions to .typos.toml
Pase: Legitimate biochemical term for phosphatase enzymes (e.g., KKPase, KPase)Ba: Part of legitimate BaF3 cell line name in scientific data filesTest Plan
typoscommand - passes without errorsFiles Modified
.typos.toml- Added exceptions for scientific termsdocs/- Fixed typos in documentationsrc/- Fixed typos in source code commentstest/- Fixed typos in test filesResolves the failing typos CI check from https://github.com/SciML/Catalyst.jl/actions/runs/16664888691/job/47169097692?pr=1306
🤖 Generated with Claude Code