feat: pass resid_prototype as u to null oop NonlinearLeastSquaresProblem
#1149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AayushSabharwal
force-pushed
the
as/null-sol-resid-prototype
branch
from
e1b6e19 to
2dd9348
Compare
| @@ -776,7 +776,7 @@ function build_null_solution( | |||
| resid = isnothing(prob.f.resid_prototype) ? Float64[] : copy(prob.f.resid_prototype) | |||
| prob.f(resid, prob.u0, prob.p) | |||
| else | |||
| resid = prob.f(prob.u0, prob.p) | |||
| resid = prob.f(prob.f.resid_prototype, prob.p) | |||
There was a problem hiding this comment.
Only do this if u0 === nothing? Why is this needed though?
There was a problem hiding this comment.
build_null_solution is only called when prob.u0 === nothing
There was a problem hiding this comment.
This is necessary because otherwise the OOP form doesn't know what sort of array to create
There was a problem hiding this comment.
I see, makes sense in its own way.
ChrisRackauckas
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.