Possible solution to repeated callbacks at dt=0 #1150
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Possible solution to SciML/ModelingToolkit.jl#3327 . I don't like this solution though because the way it works is that it allows it to catch a dt=0 case by eliminating the bottom_t from matching t, and then checking if the nonlinear solver did not converge, and then setting error_occured on that. I think it's possible to construct a bug where in the interval (t0,t1) you have an event `t2` and an "event" found at t0, this will search for the first event so it will narrow the intervals to `t3 < t2` and then do the search on (t0,t3), then fail, and so it would say there is no event.
|
pinging @BenChung since I know he's thought a lot about this. |
|
It ended up even weirder than I thought. It was SciML/OrdinaryDiffEq.jl#2695 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible solution to SciML/ModelingToolkit.jl#3327 . I don't like this solution though because the way it works is that it allows it to catch a dt=0 case by eliminating the bottom_t from matching t, and then checking if the nonlinear solver did not converge, and then setting error_occured on that. I think it's possible to construct a bug where in the interval (t0,t1) you have an event
t2and an "event" found at t0, this will search for the first event so it will narrow the intervals tot3 < t2and then do the search on (t0,t3), then fail, and so it would say there is no event.