Skip to content

fixes tests that were broken by SciMLBase PR 1101 #1192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

thomvet
Copy link
Contributor

@thomvet thomvet commented Aug 14, 2025

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

SciML/SciMLBase.jl#1101 made it so that (SciMLBase.AbstractSciMLFunction <: Function) == false which broke tests here. This makes those tests working again.

@ChrisRackauckas ChrisRackauckas merged commit b701a2d into SciML:master Aug 14, 2025
43 of 48 checks passed
@thomvet thomvet deleted the fix-tests-broken-by-SciMLBase1101 branch August 15, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants