Replace RandomNumbers.jl dependency with direct Random123.jl usage #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove RandomNumbers.jl dependency from Project.toml - Replace RandomNumbers.Random123.Threefry4x() with Random123.Threefry4x() - Replace RandomNumbers.Random123.set_counter! with Random123.set_counter! - Update test files to use Random123 directly instead of RandomNumbers - Replace Xorshifts.Xoroshiro128Plus with Random123.Threefry4x in tests This addresses the issue where Random123 is no longer part of RandomNumbers.jl, fixing bridge tests and other functionality that depends on Random123 generators. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add Random123 to [extras] section for test availability - Add Random123 to test targets since it's used in VBT_test.jl and two_processes.jl This ensures Random123 is available during testing while keeping it as a regular dependency for runtime usage.
Additional Fix: Test DependenciesI've added an additional commit to properly configure Random123 for testing: ✅ Added Random123 to [extras] section in Project.toml This ensures Random123 is available during testing while keeping it as a regular dependency for runtime usage. Thanks for catching this! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the issue where Random123 is no longer part of RandomNumbers.jl by replacing the RandomNumbers.jl dependency with direct Random123.jl usage.
Problem
Random123 was previously accessed through RandomNumbers.jl, but is now a separate package. This was causing issues with bridge tests and other functionality that depends on Random123 generators.
Changes Made
Dependencies
Source Code Updates
import RandomNumbers: Xorshiftsandimport RandomNumbers, kept onlyimport Random123RandomNumbers.Random123.Threefry4x()toRandom123.Threefry4x()RandomNumbers.Random123.set_counter\!toRandom123.set_counter\!Test Updates
Xorshifts.Xoroshiro128PluswithRandom123.Threefry4xTesting
Benefits
This is a targeted fix that resolves the Random123/RandomNumbers dependency issue without changing the underlying mathematical behavior.