Skip to content

restore ForwardDiff@1.0 compat #2835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

oscardssmith
Copy link
Member

@ChrisRackauckas it appears you vibe-coded this into breaking.

@ChrisRackauckas
Copy link
Member

No I pulled it back, why would v1 be required?

@oscardssmith
Copy link
Member Author

we generally don't force users to use old packages. Why are we doing so here? Is ForwardDiff@1 causing problems?

@ChrisRackauckas
Copy link
Member

It was having resolving issues in some cases.

@oscardssmith
Copy link
Member Author

removing options for packages won't help that...

Copy link
Member

@ChrisRackauckas ChrisRackauckas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see, that snuck into #2826

@ChrisRackauckas ChrisRackauckas merged commit 176b5fc into SciML:master Aug 11, 2025
128 of 195 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants