Remove Julia v1.9 get_extension compatibility code #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since all SciML packages now require Julia v1.10+, we can remove the compatibility checks for `isdefined(Base, :get_extension)` as package extensions are available in all supported Julia versions. This removes unnecessary version checks in extension loading code.
ChrisRackauckas
commented
Jul 27, 2025
|
@thazhemadam why is there a v1.6 test here? It's not in the .github actions script 😅 . I'll merge as others passed but, that's definitely odd in the CI setup. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This has been fixed now. There was a repository rule defined which required a job with the name "Tests 1.6" to pass, and when there was none, it just perpetually blocked the auto-mergeability. I've removed updated to rule to check for lts instead. |
|
oh 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the compatibility checks for
isdefined(Base, :get_extension)since all SciML packages now require Julia v1.10+, where package extensions are built-in.Changes
Context
As identified in the SciML-wide analysis, all SciML packages have moved to requiring Julia v1.10+ as the minimum version. This makes the compatibility code for checking whether package extensions are available redundant.
The
isdefined(Base, :get_extension)checks were used to support Julia v1.9 where extensions were loaded differently. Since we no longer support v1.9, this code can be safely removed.Testing