Skip to content

prepare transition #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2025
Merged

prepare transition #155

merged 1 commit into from
Apr 27, 2025

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Dec 17, 2024

Closes #152. Cc @jamesobutler

@@ -1,6 +1,7 @@
BSD 3-Clause License

Copyright (c) 2020, Philip Meier
Copyright (c) 2020-2024, Philip Meier
Copyright (c) 2024-, Slicer Community
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going by the suggestion from #152 (comment). SlicerPyTorch uses

This Agreement covers contributions to and downloads from the 3D
Slicer project ("Slicer") maintained by The Brigham and Women's
Hospital, Inc. ("Brigham")

LMK what you prefer.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcfr, thoughts on "Slicer Community" being listed here? I don't think we necessarily need to bring Brigham into the conversation here as this is not directly Slicer related or adopting the Slicer license.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In practice, copyright needs to be associated with a legal entity. So here are some options:

Copyright (c) 2024-, Brigham and Women's Hospital (BWH)

or

Copyright (c) 2024-, Kitware, Inc.
Copyright (c) 2024-, Revvity, Inc.

That said, we could also consider specifying copyright as significant contribution are made ?

cc: @lassoan @pieper

Comment on lines +22 to +23
maintainers = [
{ name = "Slicer Community"},
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LMK if you want to add a contact email here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be @jamesobutler and myself (@jcfr)

@jamesobutler
Copy link
Collaborator

Thanks for this draft @pmeier. We can integrate the changes as-is and I make updates to the listed author upon further discussions with the other Slicer devs prior to cutting a new release of this package. Or we can wait for those discussions to complete. To not bother you with this transfer, if you can provide me Admin role of this repository I will transfer it into the Slicer GitHub organization. All links to https://github.com/pmeier/light-the-torch will automatically redirect to the future https://github.com/Slicer/light-the-torch regardless if this PR is integrated before the transfer or not.

@pmeier
Copy link
Collaborator Author

pmeier commented Apr 27, 2025

@jamesobutler Can we move forward with this PR or something similar? I'd rather not be assigned by default to new issues from CI like #159.

Copy link
Collaborator

@jamesobutler jamesobutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we can proceed now to help prevent issues being assigned to you. We will update the licensing stuff as needed before a next official release is cut.

@jamesobutler jamesobutler marked this pull request as ready for review April 27, 2025 16:03
@jamesobutler jamesobutler merged commit a036b52 into main Apr 27, 2025
94 of 95 checks passed
@jamesobutler jamesobutler deleted the prepare-transition branch April 27, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

light-the-torch future maintenance discussion
3 participants