-
Notifications
You must be signed in to change notification settings - Fork 4
Added documentation for SPI_PROCESSING
#66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
805864c
to
3b8655c
Compare
I'll add something about swift-java is short-circuiting However, in order to actually build the package on a machine the has Java installed, it will have to conditionally re-enable it by skipping the short-circuit if Since it's unlikely we'll ever ship an analysis or validation image with Java installed we really need both variables to offer this kind of control to package authors. |
It's actually not a critical distinction to have |
4201825
to
3b8655c
Compare
The additions look good to me. Merge if you're happy with them. 👍 |
I'd accidentally pushed it to the existing branch instead of a new one. Hard pushed it back and opened a PR instead now! |
Document SPI_BUILD env variable
Hold on, CI is failing |
I thought that was a persistent issue on this repo, it's certainly not related to documentation changes. It's the |
Yeah, it's clearly not change related but the latest release (1.10.0) did pass CI, so something must have changed in the meantime. I'll take a look. |
In the "Common Use Cases" article. It's not ideal here as this article says it's specifically about the
.spi.yml
file, but I think it's OK as this is where we talk about the build system.