-
Notifications
You must be signed in to change notification settings - Fork 49
Add signed/fixedpoint properties #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is freaking awesome. Thanks for doing this!
I left a handful of comments. Mostly cleanup and simplifications
Also, since I assume you're mirroring this change in VHDL, you'll want to match the version. This will end up being released under |
Thanks for the feedback! I've implemented all your suggestions. I also fleshed out the docs a bit and added some examples. I can squash all these commits if you'd like, or I assume Github can squash them automatically when merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thanks again for doing this, and being such a good PR submitter. Its rare that I get such a high quality PR.
Description of change
Add support for the
is_signed
,intwidth
, andfracwidth
properties as discussed in SystemRDL/#188.For a full description of the new features, see the updated documentation included in the PR.
Checklist