Skip to content

Conversation

darsor
Copy link
Member

@darsor darsor commented May 7, 2025

Description of change

Add support for the is_signed, intwidth, and fracwidth properties as discussed in SystemRDL/#188.

For a full description of the new features, see the updated documentation included in the PR.

Checklist

  • I have reviewed this project's contribution guidelines
  • This change has been tested and does not break any of the existing unit tests. (if unable to run the tests, let us know)
  • If this change adds new features, I have added new unit tests that cover them.

Copy link
Member

@amykyta3 amykyta3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is freaking awesome. Thanks for doing this!
I left a handful of comments. Mostly cleanup and simplifications

@amykyta3
Copy link
Member

Also, since I assume you're mirroring this change in VHDL, you'll want to match the version. This will end up being released under regblock v1.1.0

@darsor
Copy link
Member Author

darsor commented May 15, 2025

Thanks for the feedback! I've implemented all your suggestions. I also fleshed out the docs a bit and added some examples.

I can squash all these commits if you'd like, or I assume Github can squash them automatically when merging.

Copy link
Member

@amykyta3 amykyta3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Thanks again for doing this, and being such a good PR submitter. Its rare that I get such a high quality PR.

@amykyta3 amykyta3 merged commit d2b4911 into SystemRDL:main May 15, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants