Skip to content

Convert cypher expression to lynxExpression of limit and skip #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Convert cypher expression to lynxExpression of limit and skip #372

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2733da
convert cypher expression to lynxExpression of limit and skip
LianxinGao Oct 18, 2022
518a330
Merge branch 'main' into convert_skip_limit
LianxinGao Oct 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lynx/src/main/scala/org/grapheco/lynx/logical/translator/LogicalLimitTranslator.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

package org.grapheco.lynx.logical.translator

import org.grapheco.lynx.expression.utils.ConvertExpressionToLynxExpression
import org.grapheco.lynx.logical.plan.LogicalPlannerContext
import org.grapheco.lynx.logical.{LogicalLimit, LogicalNode}
import org.opencypher.v9_0.ast.Limit
Expand All @@ -24,8 +25,9 @@ case class LogicalLimitTranslator(limit: Option[Limit]) extends LogicalNodeTrans
)(implicit plannerContext: LogicalPlannerContext
): LogicalNode = {
limit match {
case None => in.get
case Some(Limit(expr)) => LogicalLimit(expr)(in.get)
case None => in.get
case Some(Limit(expr)) =>
LogicalLimit(ConvertExpressionToLynxExpression.convert(expr))(in.get)
}
}
}
3 changes: 2 additions & 1 deletion lynx/src/main/scala/org/grapheco/lynx/logical/translator/LogicalSkipTranslator.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

package org.grapheco.lynx.logical.translator

import org.grapheco.lynx.expression.utils.ConvertExpressionToLynxExpression
import org.grapheco.lynx.logical.plan.LogicalPlannerContext
import org.grapheco.lynx.logical.{LogicalNode, LogicalSkip}
import org.opencypher.v9_0.ast.Skip
Expand All @@ -25,7 +26,7 @@ case class LogicalSkipTranslator(skip: Option[Skip]) extends LogicalNodeTranslat
): LogicalNode = {
skip match {
case None => in.get
case Some(Skip(expr)) => LogicalSkip(expr)(in.get)
case Some(Skip(expr)) => LogicalSkip(ConvertExpressionToLynxExpression.convert(expr))(in.get)
}
}
}