Always refer to Button Descriptor for mappings, Trigger Fire/Release methods simplification #75
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a lot of redundancies regarding how Trigger Fire/Release methods worked - now it's just the two methods, with an if-check to determine whether to invoke FFB monitoring or not.
Button Descriptors are now always used when referring to which buttons to change function of or press in the Trigger methods; this is essentially prep-work for Custom Mappings.
Offscreen Button mode, instead of being a bespoke thing, now simply modifies the ButtonDesc table so that Trigger's Offscreen Key Code is the same as the A Button's Onscreen Key.
The LightgunButtons library is modified so that the first key (correlating to the index for
BtnIdx_Trigger
) doesn't process button events, but still handles debouncing logic, since this is all handled by the main method withinOpenFIREmain
.