Multi position file save #1129
Merged
Multi position file save #1129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added type annotations and improved code style in MultiPositionController for better readability and maintainability. Enhanced the test suite for loading positions from YAML, including more comprehensive mocking and validation of DataFrame structure.
Don't let changes to the fixture propagate to other tests... Avoid this by creating an isolated controller...
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1129 +/- ##
===========================================
+ Coverage 53.93% 54.02% +0.09%
===========================================
Files 191 191
Lines 21953 21962 +9
===========================================
+ Hits 11840 11865 +25
+ Misses 10113 10097 -16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AdvancedImagingUTSW
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yml files now supported. Unit test included