Skip to content

Bug (applications installation doesn't work). #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

classy-giraffe
Copy link
Contributor

By removing the -h flag (which is meant for help), now it works flawlessly.

By removing the -h flag (which is meant for help), now it works flawlessly.
@TheTechsTech
Copy link
Owner

By removing the -h flag (which is meant for help), now it works flawlessly.

It's not meant for help, but silent install see https://docs.microsoft.com/en-us/windows/package-manager/winget/install#options

Could be something else going on with your setup, there shouldn't be any other required local actions needed. It also might be the typescript support features recently added.

Should add tests showing bugs on this and other PR, current tests shows neither as an issue anyway.

I initially merged cause it didn't cause current tests to fail. It didn't prove PR is correct for proving fix.

@classy-giraffe
Copy link
Contributor Author

We are using Choco though, not Winget. On the former, -h is just a short for choco help.

@TheTechsTech
Copy link
Owner

Looking into it a little further, Windows winget support was recently added in, and checks for that first.

The patch should check for which packager manager is being actually used. You only fixed your issue, a bug is still present, a problem is created with winget usage.

@classy-giraffe
Copy link
Contributor Author

Yes, but in the case Winget is not found which is my case, it tries to hook up chocolatey which leds to the problem I mentioned in the issue. -h should be removed.

@TheTechsTech
Copy link
Owner

You need to update PR to check for which package manager is being used/found and pass what it needs. Yes, this should have been done when winget support was added. You current PR will just break winget though.

As I rather be only using a native platform/os manager. I never like chocolatly, the install process. Getting winget is simpler and native.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants