-
Notifications
You must be signed in to change notification settings - Fork 134
Compact dockerfile #1202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compact dockerfile #1202
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds two new options—single_file
and set_golem.app.prod
—to the Dockerfile helpers, updating code and documentation so that multi-stage Dockerfiles are generated by default and golem.app.prod=TRUE
is set automatically.
- Introduce
single_file
andset_golem.app.prod
parameters across alladd_dockerfile_with_renv_*
functions - Implement branching logic for single‐ vs. two‐stage Dockerfile generation
- Update documentation and NEWS to describe the new defaults
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
man/dockerfiles.Rd | Added single_file and set_golem.app.prod to function docs |
R/add_dockerfiles_renv.R | Added branching for multi-stage builds; new default options |
NEWS.md | Noted new defaults in release notes |
DESCRIPTION | Bumped dockerfiler dependency to ≥ 0.2.5 |
Comments suppressed due to low confidence (3)
R/add_dockerfiles_renv.R:449
- In
add_dockerfile_with_renv_shinyproxy
, thedockerfile_cmd
does not include thegolem.app.prod
option, soset_golem.app.prod
is ignored. Update the command tooptions(..., golem.app.prod = %s)
to honor that flag.
"R -e \"options('shiny.port'=3838,shiny.host='0.0.0.0');library(%1$s);%1$s::run_app()\""
R/add_dockerfiles_renv.R:158
- [nitpick] This call uses
get_golem_name(pkg = source_folder)
but elsewhere you useget_golem_name(golem_wd = golem_wd)
. Standardize on one signature to avoid confusion and ensure consistency.
paste0(get_golem_name(pkg = source_folder), "_*.tar.gz")
man/dockerfiles.Rd:186
- [nitpick] Remove the extra space before the period and consider clarifying default notation (e.g.,
(default: TRUE)
) to match other parameter descriptions.
If \code{TRUE} (by default), generate a single multi-stage Dockerfile .
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
bump version
No description provided.