-
Notifications
You must be signed in to change notification settings - Fork 6
Switch to dependency-groups
#585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modernizes dependency management by migrating from the legacy [project.optional-dependencies]
syntax to the new [dependency-groups]
format introduced in PEP 735. This change affects how development, documentation, and testing dependencies are declared and installed.
- Replaces
optional-dependencies
withdependency-groups
in pyproject.toml files - Updates tox configuration to use
dependency_groups
instead ofextras
- Updates installation commands in documentation to use
--group
flags instead of extras syntax
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
{{cookiecutter.project_slug}}/pyproject.toml | Migrates dependency declarations from optional-dependencies to dependency-groups and updates tox configuration |
tutorial.md | Updates installation command examples to use --group syntax |
tests/data/test_package_generation/pyproject.toml | Applies the same dependency-groups migration to test data |
README.md | Updates quick start installation command to use --group syntax |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, was trying to distribute load! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell the --group
option was only added to uv pip install
in version v0.8.1, which was released yesterday? And it is only available in pip install
from v25.1 (released in April 2025). As it's quite likely users won't have the latest uv
and/or pip
versions installed, it might be worth adding a note to instructions in tutorial and README that if you get an error when using the --group
argument you may need to update you version of uv
/ pip
.
|
Link checker failing is unrelated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, a couple of suggestions but nothing blocking
Co-authored-by: Paul Smith <paul.j.smith@ucl.ac.uk>
Co-authored-by: Paul Smith <paul.j.smith@ucl.ac.uk>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Fixes #570. Move to the modern
[dependency-groups]
syntax for non-user facing additional dependencies. See PEP 735.