[DO NOT MERGE] fix: prevent network modal from opening randomly on reconnect #6272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomiir
approved these changes
Apr 29, 2025
|
Missing changesets 🙏 |
magiziz
changed the title
magiziz
force-pushed
the
fix/reset-apkt-state-on-disconnect
branch
from
7b6e73d to
aa0bd7f
Compare
|
Will try to do this on the appkit level |
magiziz
force-pushed
the
fix/reset-apkt-state-on-disconnect
branch
from
d81293f to
9a6afcd
Compare
magiziz
commented
Apr 30, 2025
| @@ -619,6 +619,7 @@ export class EthereumProvider implements IEthereumProvider { | |||
| ...options, | |||
| universalProvider: this.signer as any, | |||
| manualWCControl: true, | |||
| enableNetworkSwitch: false, | |||
There was a problem hiding this comment.
The fix is done on the appkit side. but setting enableNetworkSwitch to false will make sure the network modal doesn’t open just in case appkit has any issues again
magiziz
changed the title
magiziz
changed the title
magiziz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When attempting to reconnect after disconnecting, the EP opens the appkit account modal view. This happens because the appkit state is not reset after disconnection.
Type of change
How has this been tested?
Tested on Uniswap and locally
Examples/Screenshots (Optional)
repro.mov
Checklist