Skip to content

Conversation

enesozturk
Copy link

Description

This PR upgrades AppKit to the version which is using Valtio v2.

Note

This PR won't be merged untill we verify this migration flow below works fine.

Migration guide

  • Upgrade Valtio to v2 on AppKit and open PR
  • Get AppKit canary: 1.7.12-valtio-v2.0
  • Update AppKit to Valtio v2 canary on WC packages
  • Get WC packages canary
  • Use this canary in AppKit (so both AppKit and WC packages will be using Valtio v2)
  • Update AppKit Valtio v2 PR with WC canary

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • If all good, merge WC and AppKit PRs.

How has this been tested?

This will be tested on AppKit PR: reown-com/appkit#4358

Fixes/Resolves (Optional)

Fixes issue when switching to Valtio v2 on AppKit bc the WC dependencies brings Valtio v1 and both Valtio dependencies are conflicting. AppKit repo requires AppKit version which uses Valtio v2

Checklist

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Additional Information (Optional)

Please include any additional information that may be useful for the reviewer.

@enesozturk enesozturk requested a review from ganchoradkov June 30, 2025 13:14
Copy link

socket-security bot commented Jun 30, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​reown/​appkit@​1.7.8 ⏵ 1.7.12-valtio-v2.1.09910084 +1098100

View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant