Faster locking through .NET 9's System.Threading.Lock #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeihanLi
reviewed
Aug 12, 2024
src/WeihanLi.Common.Logging.Serilog/WeihanLi.Common.Logging.Serilog.csproj
Outdated
Show resolved
Hide resolved
WeihanLi
reviewed
Aug 12, 2024
|
Thanks for the PR, do we have any benchmark data about this change |
Basically System.Threading.Lock on .NET 9.0 is benchmarked to be around 25% faster. This PR brings this performance improvement into existing locks for .NET 9+ projects depending on this library. https://steven-giesel.com/blogPost/4cf6d48a-ec9d-4c68-961c-31fd8d8c1340 |
|
Not sure what the CI issue is but I was informed about something I should do to the library so I will release a new version. Don't merge yet. |
|
Updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.