Skip to content

Conversation

ZabuzHere
Copy link

Adding Support UI

@Wertzui123
Copy link
Owner

Hey! First of all, thank you for your PR! I haven't had time to look into it yet, but I will try to do so next week. Sorry for the delay.

@Wertzui123
Copy link
Owner

Ok, so, I've taken a look at your PR now, and unfortunately, there are a few things that need to be changed before I can merge it.

Firstly, you're using hardcoded messages in your code, but the rest of BedrockClans dynamically fetches messages from the config files using getMessage and getString. That way, users can customize and localize all messages sent by BedrockClans. Please update your code to make use of this system.

Secondly, you have embedded some code for creating forms, which seems to be taken from FormAPI. However, you have not included any copyright notices, licenses, or credits, which constitutes plagiarism. Please remove this code and maybe use a virion instead.

Thirdly, I've seen that you have also made significant changes to the /clan info subcommand. This is out of scope for this PR. Please revert these changes.

Also, since UI is commonly spelled with both letters uppercase, I would also use this spelling in code, e.g. UISubcommand instead of UiSubcommand - what do you think?

Sorry again for the delay. I'm currently rather busy, but I will try to help you out as best as I can should any further questions or issues arise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants