Do not create a Warning if you could not get the current monitor status from the DB (Monitor.php) #4097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…us from the DB (Monitor.php) The only reason why the status could not be obtained is the absence of a monitor in the 'Monitor_Status' table. For example - Montage page is open and - at this moment the connection with the camera is lost - go to the camera settings and resave - disabled Capturing - and so on. In all of the above cases, a useless warning will be generated that only fills the log. Or am I wrong?
|
If there isn't a status update in over a minute, the records will get deleted. SO this could actually happen, although I've never seen it logged.. So I'm tempted to agree with you, Maybe it could be debug level. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only reason why the status could not be obtained is the absence of a monitor in the 'Monitor_Status' table. For example - Montage page is open and
Or am I wrong?