Feat: Added left side menu #4311
Conversation
IgorA100
changed the title
…/pro-sidebar-template" (functions.php)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
If new menu is used, then Datepicker initialization occurs in main "skin.js" Reinitialization is not allowed because the 'Destroy' method is missing.
Removed unused code
…e it is inconvenient to delete more than 2-3 elements one by one.
This is a rough draft for review. Some of the code will be moved to other CSS files. Comments will be changed.
|
@connortechnology |
|
@connortechnology |
|
I do not have time to look at it. It will not go in 1.38. It will get merged likely immediately after 1.38 is released, as 1.39.0 |
… hiding datepicker (skin.js)
|
@connortechnology |
|
Looks great, looking forward to this! Thank you greatly @IgorA100 for your excellent work! |
Thank you. That's great to hear! |
|
I'm not doing so well at getting 1.38 out, so I might take a look at this over the next couple days with an eye to merging it before 1.38. Stay tuned. |
|
Requires addition from 762ee7a |
|
@connortechnology Haven't you looked at this PR? |
|
I did, it didn't apply cleanly to the branch I was working on. I do think I will try to get it in soon before 1.38 release. |
Did you like it or do you have any suggestions? |
|
What are the X buttons for in the filter menu? Are they for when not using chosen? I guess if you had multiple things chosen it would be nice to be able to clear them all... which explains why they don't appear for the text inputs... Maybe give them a title like "Clear all" so that it is clear on mouse over. I see no reason to have a use old/new menu toggle in the main UI. Move it to options -> Web. Also, there is a thing about the words Old/New. They connotate old=busted,bad vs new=good. There is an implied value statement. I would prefer a more accurate less judgey term like Top Menu / Left Menu. Also, some people might want both. It shouldn't be an either/or. |
|
I'm not sure why things are going in assets. WHy another dir to contain third party stuff. We now have 3. I'd kinda like to have that cleaned up. I like all the link to docs, zmNinja etc, but some people may want to remove that to save space. We have an option for that in th eold header to remove content from home logo button. ALso support for my new NAVBAR_LINKS stuff. |
For "Clear all"
Yes. I will do that.
I did it for quick switching. Okay, I'll move it to "options -> Web"
Okay, I'll rename it.
So I need to make such a choice in the options?
|
These are three third-party plugins used to create the menu
All this is located almost at the very bottom of the menu. The menu has correct scrolling, including on mobile devices.
Ok. |
|
I do not insist, you asked for comments. I gave comments. We can wait for people to complain about the links, but for my pro users I will have to hide them. I have merged this, it looks good enough as is, we can now get comments from users. |
Thank you! I am really interested in this.
Why do you need to do this? Since it is critical for you, I can analyze the "HOME_ABOUT" setting and hide or show additional links. |
Closed #4077