Skip to content

Conversation

IgorA100
Copy link
Contributor

No description provided.

@connortechnology
Copy link
Member

co-pilot says this has issues. You might try playing around with it.

My only thought on the matter is wow this is getting nasty.

Why is it needed?

@IgorA100
Copy link
Contributor Author

Why is it needed?

At the moment we have <select #streamQuality> used for ZMS and <select #streamChannel> used for Go2RTC and RTSP2Web. They are both in the document. Depending on which player is enabled, one or the other is displayed. Chosen will apply to both in Yoga, both will be displayed, which is incorrect.
You can use one and rebuild it with JS, but this will complicate the code a little and increase the load on the browser a little. And in general, it seems logical to me not to apply "chosen" to any hidden , because it will break the UI.

@IgorA100
Copy link
Contributor Author

co-pilot says this has issues.

Resolved

@IgorA100
Copy link
Contributor Author

is getting nasty

Why?
It seems logical to me not to display hidden to which "chosen" is applied Of course, you can analyze the object before applying "chosen" and if it has a hiding class, then do not apply "chosen" to it, but this will again complicate the code and you will always need to remember this....

@connortechnology connortechnology merged commit e712b55 into ZoneMinder:master Jul 26, 2025
14 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants