Fix: When changing the player and after starting the stream (hiding - displaying the page), you also need to call monitorsSetScale() on Watch page #4400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…() (watch.js) Otherwise, there may be problems with the image if we were viewing using "ZMS MJPEG" and then switched, for example, to the Go2RTC secondary channel and we have different image proportions for "ZMS MJPEG" always using the primary channel and Go2RTC using the secondary channel
…ecute monitorsSetScale() (watch.js) You also need to reset the previous state prevStateStarted, otherwise after the first triggering (document.visibilityState != "hidden") after hiding and then displaying the page, the stream will be restarted within 15 seconds, and this should not happen.
IgorA100
changed the title
|
I also added this to this PR: You also need to reset the previous state prevStateStarted, otherwise after the first triggering (document.visibilityState != "hidden") after hiding and then displaying the page, the stream will be restarted within 15 seconds, and this should not happen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, there may be problems with the image if we were viewing using "ZMS MJPEG" and then switched, for example, to the Go2RTC secondary channel and we have different image proportions for "ZMS MJPEG" always using the primary channel and Go2RTC using the secondary channel