Feat: Added <select> to control enabling players on Monitor page #4428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code implements support for disabling ALL players, including "ZMS MJPEG", but the UI does not currently use disabling all players. Because at the moment I am not sure that it is necessary to disable all players.
To implement enabling/disabling "ZMS MJPEG" you need to uncomment some lines of code and add a field to the DB
ALTER TABLEMonitorsADD COLUMNZMSEnabledBOOLEAN NOT NULL default true AFTERDecoding``It looks like this: #4393 (comment)
Also added the ability for
<input>to use ".disabled", because if you use the "disabled" attribute for<input>, then the value of<input>will not be used in the form. And now, if you add the "disabled" class, then the value of<input>will be used in the form, but you cannot change its value manually in the UI.If this PR is approved, then in the future you can remove the checkboxes for controlling player enablement from the UI and visually combine the options into the Go2RTC, RTSP2Web & Janus groups
I'm not sure about the feasibility of this PR, but I had some ideas and decided to publish them. Probably, choosing to enable/disable players in one place (in "multi select") is better than many checkboxes.