-
Notifications
You must be signed in to change notification settings - Fork 53
Add automatic configuration capability and other enhancements for Offline Mode #728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…t for i2c component auto workflow within it
…nt write out its types, device default_sensor_types is broken
@tyeth This PR is passing and ready for review and testing. Note that you do not need to review every i2c |
Hardware Tested: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was some funkiness with the checksum messaging when using offline mode. I think maybe it says mismatch and then successfully verified. Maybe worth quickly checking.
I meant to add that checksum to the config tool too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the filename and folder suffix looks like a typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how - would you prefer a rename?
I fixed this sometime on Thursday and didn't see this while testing. I also verified it against the invalid_checksum unit test scenario:
|
This pull request adds:
config.json
file is now built automatically!config.json
file and then upload it to a board running WipperSnapper's Offline Mode.config.json
file is constructed during runtime and appears on the first run of the Offline Mode firmware.config.json
file, then falls back and attempts to initialize based on a#define
withinws_boards.h
fileconfig.json
file, without manually editing the file.config.json
file are initialized firstconfig.json
file to allow it to persist between boots.config.json
) and the new, discovered, components.