Skip to content

[Offline Mode] Fix Config file deletion, RTC initialization failure #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 13, 2025

Conversation

brentru
Copy link
Member

@brentru brentru commented May 2, 2025

Resolves: #735

This pull request:

  • Improved error handling in Wippersnapper_FS::CreateFileConfig by raising an error if config.json cannot be deserialized, instead of silently removing it. (src/provisioning/tinyusb/Wippersnapper_FS.cpp)
  • Ensured proper cleanup of the old config.json file before writing a new one in Wippersnapper_FS::WriteFileConfig. This prevents potential conflicts or corruption. (src/provisioning/tinyusb/Wippersnapper_FS.cpp)
  • Uses the proper I2C bus when initializing the RTC chip by getting a ptr to the bus from the controller rather than assuming a default.

@brentru brentru requested a review from tyeth May 2, 2025 18:42
Copy link

github-actions bot commented May 2, 2025

Test Results

6 tests  ±0   6 ✅ ±0   41s ⏱️ -1s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 11e2116. ± Comparison against base commit 5564777.

@brentru brentru changed the title Fixes for Offline Mode Issues - Config file deletion, RTC initialization failure [Offline Mode] Fix Config file deletion, RTC initialization failure May 2, 2025
@tyeth tyeth merged commit 11e2116 into offline-mode May 13, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants