-
Notifications
You must be signed in to change notification settings - Fork 53
Offline mode new boards+components. #788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offline mode new boards+components. #788
Conversation
Offline mode ina refactor from flat0808
Interesting to note that the wokwi tests don't run on external contributor PRs. |
I'd missed the HDC302x, found in testing. Now all running as expected, SCD40 (0x62), HDC3022 (0x47), INA228 +237 +238 + 260.
|
…b.com/tyeth/Adafruit_Wippersnapper_Arduino into offline-mode-flattened-new-2025-08-08
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments, overall a very strong PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Oh, check that one failing check before merging |
This adds the xiao and espressif s3 devkit boards, the sense camera addon (SD), and expansion board (rtc/sd/oled/grove).
Adds the drivers for the omron d6t, plus PCF8563 RTC on xiao grove expansion board (part of RTCLib already)
Adds the INA228, and does the INA 260/237/238 refactor, linked to Ina238 + 237 via a refactor of INA260 too. #765
Updates the build CI step inline with main, for the online job, and the offline job has been similarly updated.
Adds a build define for wokwi, to allow switching the platformio sketch file (src/sketch) between network adapters.
Updates the autoconfig flag to also support globally disabling the auto config. Reason being it can crash repeatedly when attempting to initialise undefined components so the user never sees the error nor has time to remove the config file (except fast repeated shell commands to delete/remove the file).
Hey Brent, the auto config routine tried to initialise something (an unknown i2c rtc) as a vcnl4200 then rebooted. I couldn't disable the auto config globally and it scans then runs for found+unused i2c addresses.
So I've added support for autoConfig: false at the exportedDeviceConfig object level, so it can be specified per component or globally.
The XIAO has an rtc that's nearly the same so I've added that too (PCF8563 instead of -23), including now avoiding scanning that address (0x51) like the other rtc and mux address checks (0x68 + 0x70).
Maybe we could be smarter about the scanning of those addresses and still do so if the user has an already equivalent RTC/Mux component defined (e.g. if already defined soft rtc then they could auto scan 0x68 and 0x51, if defined pcf8523 then that frees up 0x51 for scanning, if a mux at not 0x70 then we can scan 0x70 looking for normal device components safe in the knowledge the only mux is at 0x71 or whatever the user defined)