Skip to content

fix(CI): make git version work on forks #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2025

Conversation

tyeth
Copy link
Member

@tyeth tyeth commented Aug 18, 2025

The CI jobs should be able to run successfully in peoples forks of our repo, but currently the get version step fails due to missing tags.

This step resolves that, fetching all tags (i.e. not just the fork), and then falling back to 1.0.0-${REPO_OWNER}-${COMMIT_REF}

@tyeth tyeth requested a review from brentru August 18, 2025 18:43
@brentru
Copy link
Member

brentru commented Aug 18, 2025

@tyeth This PR is failing due to nanopb, re-running failed targets

@tyeth
Copy link
Member Author

tyeth commented Aug 18, 2025 via email

@brentru
Copy link
Member

brentru commented Aug 18, 2025

@tyeth passing ci now

@tyeth tyeth merged commit e06ebab into adafruit:main Aug 18, 2025
68 of 90 checks passed
@tyeth tyeth deleted the git-describe-fork-fix branch August 18, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants