fix(s2): update button gradients to use static colors #7574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jluyau
commented
Jan 6, 2025
| @@ -111,8 +113,8 @@ export function colorMix(a: SpectrumColor, b: SpectrumColor, percent: number): ` | |||
| return `[color-mix(in srgb, ${parseColor(a)}, ${parseColor(b)} ${percent}%)]`; | |||
| } | |||
|
|
|||
| export function linearGradient(angle: string, ...tokens: [SpectrumColor, number][]): string { | |||
| return `linear-gradient(${angle}, ${tokens.map(([color, stop]) => `${parseColor(color)} ${stop}%`)})`; | |||
| export function linearGradient(angle: string, ...gradientTokens: [(keyof typeof tokens), (keyof typeof tokens)][]): string { | |||
There was a problem hiding this comment.
unsure if making this function accept only tokens is ok. currently only used by the gradient buttons, but in the case someone else wanted to use it, it might need to accept color token as well?
jluyau
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update Button gradients (genai & premium) to use static colors as to not change for light/dark theme
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: