Skip to content

chore: Build S2 Next.js example in verdaccio and add more components #7794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Aug 18, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
164c331
add more components to s2 example
reidbarber Feb 19, 2025
80deaa1
add s2 next.js example to verdaccio build
reidbarber Feb 19, 2025
3801272
add to CI comment
reidbarber Feb 19, 2025
e367b40
enable verdaccio build on branch
reidbarber Feb 19, 2025
2f641ad
yarn fixes
reidbarber Feb 19, 2025
0dcad83
fix warnings/errors
reidbarber Feb 20, 2025
9a0c5c0
next upgrade
reidbarber Feb 24, 2025
e0bffaa
typescript routing fix
reidbarber Feb 24, 2025
a1910df
Merge remote-tracking branch 'origin/main' into s2-next-verdaccio
reidbarber Feb 24, 2025
9143e3d
Merge branch 'main' into s2-next-verdaccio
reidbarber Feb 27, 2025
b3a9c52
Merge remote-tracking branch 'origin/main' into s2-next-verdaccio
reidbarber Jul 25, 2025
88c7780
add to CI
reidbarber Aug 6, 2025
9906630
Merge remote-tracking branch 'origin/main' into s2-next-verdaccio
reidbarber Aug 6, 2025
4f085f3
add TreeView and fix types
reidbarber Aug 8, 2025
3dbe270
Merge remote-tracking branch 'origin/main' into s2-next-verdaccio
reidbarber Aug 8, 2025
1cad937
fix VERDACCIO env variable during build
reidbarber Aug 11, 2025
6055986
Merge remote-tracking branch 'origin/main' into s2-next-verdaccio
reidbarber Aug 11, 2025
f2b373c
add Provider
reidbarber Aug 11, 2025
f39cf2e
add 'use client' to app/layout.tsx
reidbarber Aug 14, 2025
500205b
Merge remote-tracking branch 'origin/main' into s2-next-verdaccio
reidbarber Aug 14, 2025
4a94676
move provider into client
reidbarber Aug 14, 2025
261ec06
add back main filters
reidbarber Aug 14, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .circleci/comment.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
const Octokit = require('@octokit/rest');
const fs = require('fs');

const octokit = new Octokit({
auth: `token ${process.env.GITHUB_TOKEN}`
Expand Down Expand Up @@ -36,13 +35,14 @@ async function run() {
repo: 'react-spectrum',
pull_number
});
// eslint-disable-next-line max-depth
if (data && data.head.repo.full_name !== 'adobe/react-spectrum' && data.head.sha === forkHeadCommit) {
pr = pull_number;
break;
}
}
} else if (process.env.CIRCLE_BRANCH === 'main') {
//If it isn't a PR commit, then we are on main. Create a comment for the test app and docs build
// If it isn't a PR commit, then we are on main. Create a comment for the test app and docs build
await octokit.repos.createCommitComment({
owner: 'adobe',
repo: 'react-spectrum',
Expand All @@ -54,6 +54,7 @@ async function run() {
[S2 Parcel Example](https://reactspectrum.blob.core.windows.net/reactspectrum/${process.env.CIRCLE_SHA1}/verdaccio/s2-parcel-example/index.html)
[S2 Custom Icons](https://reactspectrum.blob.core.windows.net/reactspectrum/${process.env.CIRCLE_SHA1}/verdaccio/icon-builder-fixture/index.html)
[S2 Webpack Example](https://reactspectrum.blob.core.windows.net/reactspectrum/${process.env.CIRCLE_SHA1}/verdaccio/s2-webpack-5-example/index.html)
[S2 Next.js Example](https://reactspectrum.blob.core.windows.net/reactspectrum/${process.env.CIRCLE_SHA1}/verdaccio/s2-next-macros/index.html)
[CRA Test App Size](https://reactspectrum.blob.core.windows.net/reactspectrum/${process.env.CIRCLE_SHA1}/verdaccio/publish-stats/build-stats.txt)
[NextJS App Size](https://reactspectrum.blob.core.windows.net/reactspectrum/${process.env.CIRCLE_SHA1}/verdaccio/publish-stats/next-build-stats.txt)
[Publish stats](https://reactspectrum.blob.core.windows.net/reactspectrum/${process.env.CIRCLE_SHA1}/verdaccio/publish-stats/publish.json)
Expand Down Expand Up @@ -84,7 +85,7 @@ async function run() {
* [View the S2 docs](https://reactspectrum.blob.core.windows.net/reactspectrum/${process.env.CIRCLE_SHA1}/s2-docs/index.html)`
});
} catch (err) {
console.error(err)
console.error(err);
}
}
}
26 changes: 26 additions & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -678,6 +678,28 @@ jobs:
paths:
- '*/verdaccio/s2-webpack-5-example'

v-s2-next:
executor: rsp-xlarge
steps:
- restore_cache:
key: react-spectrum-{{ .Environment.CACHE_VERSION }}-{{ .Environment.CIRCLE_SHA1 }}

- attach_workspace:
at: /tmp/verdaccio-workspace

- run:
name: build s2-next off verdaccio
command: |
./scripts/verdaccio-ci.sh
./scripts/verdaccio-build-s2-next.sh
environment:
VERDACCIO_STORAGE_PATH: /tmp/verdaccio-workspace/storage

- persist_to_workspace:
root: verdaccio_dist
paths:
- '*/verdaccio/s2-next-macros'

v-icon-builder:
executor: rsp-xlarge
steps:
Expand Down Expand Up @@ -914,6 +936,9 @@ workflows:
- v-s2-webpack:
requires:
- verdaccio
- v-s2-next:
requires:
- verdaccio
- v-icon-builder:
requires:
- verdaccio
Expand Down Expand Up @@ -948,6 +973,7 @@ workflows:
- v-rac-rsp-tailwind
- v-s2-parcel
- v-s2-webpack
- v-s2-next
- v-icon-builder
- v-publish-stats
- comment:
Expand Down
894 changes: 894 additions & 0 deletions examples/s2-next-macros/.yarn/releases/yarn-4.2.2.cjs

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions examples/s2-next-macros/next.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ let macrosWebpack = macrosPlugin.webpack();

/** @type {import('next').NextConfig} */
const nextConfig = {
output: 'export',
basePath: process.env.VERDACCIO && process.env.CIRCLE_SHA1 ? `/reactspectrum/${process.env.CIRCLE_SHA1}/verdaccio/s2-next-macros` : "",
webpack(config, {}) {
config.plugins.push(macrosWebpack);

Expand Down
24 changes: 14 additions & 10 deletions examples/s2-next-macros/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,25 +3,29 @@
"version": "0.1.0",
"private": true,
"scripts": {
"dev": "next dev -p 3456",
"dev": "next dev --turbopack -p 3456",
"build": "next build",
"start": "next start",
"lint": "next lint"
},
"dependencies": {
"@react-spectrum/s2": "^0.3.0",
"next": "14.1.3",
"react": "^18",
"react-dom": "^18",
"unplugin-parcel-macros": "0.0.3"
"@react-spectrum/s2": "latest",
"next": "15.1.7",
"react": "19.0.0",
"react-dom": "19.0.0"
},
"devDependencies": {
"@svgr/webpack": "^8.1.0",
"@types/node": "^20",
"@types/react": "^18",
"@types/react-dom": "^18",
"@types/react": "19.0.10",
"@types/react-dom": "19.0.4",
"eslint": "^8",
"eslint-config-next": "14.1.3",
"typescript": "^5"
"eslint-config-next": "15.1.7",
"typescript": "^5",
"unplugin-parcel-macros": "0.1.1"
},
"resolutions": {
"@types/react": "19.0.10",
"@types/react-dom": "19.0.4"
}
}
Loading