fix: show calendar header in s2 dialog

[yihuiliao]

Closes

✅ Pull Request Checklist:

• Included link to corresponding React Spectrum GitHub Issue.
• Added/updated unit tests and storybook for this change (for new code or code which already has tests).
• Filled out test instructions.
• Updated documentation (if it already exists for this component).
• Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

[rspbot]

Build successful! 🎉

• View the storybook
• View the S2 storybook
• View the documentation
• View the S2 docs

[rspbot]

Build successful! 🎉

• View the storybook
• View the S2 storybook
• View the documentation
• View the S2 docs

[rspbot]

Build successful! 🎉

• View the storybook
• View the S2 storybook
• View the documentation
• View the S2 docs

[snowystinger]

we already clear some context in

react-spectrum/packages/@react-spectrum/s2/src/DatePicker.tsx

Line 259 in 863ac42

[OverlayTriggerStateContext, null]

should we clear these there as well? then we don't need to do it in two files

[LFDanLu]

might be worth to do it at the calendar level too in case someone is using it standalone though right?

[yihuiliao]

but if a person were to just use a Calendar inside a dialog rather than a DatePicker, then wouldn't this still be an issue?

[snowystinger]

I guess maybe? it might pick up some stray context, but same argument could be made for the overlay trigger state context

[yihuiliao]

im fine adding it to CalendarPopover in DatePicker, but i think we'll still need to clear the context in Calendar and RangeCalendar for any standalone cases

[snowystinger]

they'd have the same issue with the overlaytriggerstatecontext too, so that should probably be moved to the same place

[LFDanLu]

verified locally that rangecalendar and calendar render just fine in a s2 dialog, will approve after we decide if we wanna clear it at the datepicker level too

[snowystinger]

we can followup with any small changes later, but merging so we can patch something that works