-
Notifications
You must be signed in to change notification settings - Fork 1.3k
wip: wrap default error message text in V3 DateRangePicker #8623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will run chromatic tmr
packages/@react-spectrum/datepicker/stories/DateRangePicker.stories.tsx
Outdated
Show resolved
Hide resolved
packages/@react-spectrum/datepicker/stories/DateRangePicker.stories.tsx
Outdated
Show resolved
Hide resolved
Build successful! 🎉 |
Build successful! 🎉 |
Hmm yeah so looks like Either way, seems more complicated, will work on it when I have the time but not main priority |
@@ -141,7 +141,7 @@ | |||
} | |||
|
|||
.react-spectrum-Datepicker-dialog.react-spectrum-Datepicker-dialog { | |||
width: auto; | |||
max-width: fit-content; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead, you could try
contain: inline-size;
on the :global(.spectrum-Calendar-helpText)
No idea why it's global...
imma just close it for now but might work on it later |
Closes #5860
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: