Skip to content

fix: add role to react aria taggroup when empty #8723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2025
Merged

Conversation

yihuiliao
Copy link
Member

Closes #8354

Tested it with VO before and after this change and it didn't really make a difference in terms of announcement. It always seemed to announce it as a group so I feel like this change is fine and now won't violate accessibility.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Aug 13, 2025

@rspbot
Copy link

rspbot commented Aug 13, 2025

@yihuiliao yihuiliao added this pull request to the merge queue Aug 15, 2025
Merged via the queue into main with commit 42e5a2c Aug 15, 2025
32 checks passed
@yihuiliao yihuiliao deleted the empty-taggroup-role branch August 15, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TagGroup doesn't add role attr when collection is empty
4 participants